Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: fix mypy warnings about unchecked hints #4277

Merged
merged 1 commit into from
Dec 30, 2022
Merged

TYP: fix mypy warnings about unchecked hints #4277

merged 1 commit into from
Dec 30, 2022

Conversation

neutrinoceros
Copy link
Member

PR Summary

fix current warning from mypy:

yt/data_objects/data_containers.py: note: In member "__init__" of class "YTDataContainer":
8
yt/data_objects/data_containers.py:91: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs  [annotation-unchecked]

It'd be useful to turn these notes into proper errors to avoid leaking them constantly, I'll look into it.

@neutrinoceros neutrinoceros added the enhancement Making something better label Dec 30, 2022
@neutrinoceros
Copy link
Member Author

I found no way to configure mypy to treat those as errors. I may report that as an issue later but in the mean time this is ready for review

@neutrinoceros neutrinoceros marked this pull request as ready for review December 30, 2022 14:48
@matthewturk matthewturk merged commit 9725a7d into yt-project:main Dec 30, 2022
@neutrinoceros neutrinoceros deleted the typ_warnings branch December 30, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
enhancement Making something better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @matthewturk